Skip to content

Allow structure reuse if a declaration file within a package is updated#47472

Merged
andrewbranch merged 2 commits intomicrosoft:mainfrom
JoostK:reuse-structure-dts-update
Jan 25, 2022
Merged

Allow structure reuse if a declaration file within a package is updated#47472
andrewbranch merged 2 commits intomicrosoft:mainfrom
JoostK:reuse-structure-dts-update

Conversation

@JoostK
Copy link
Copy Markdown
Contributor

@JoostK JoostK commented Jan 16, 2022

Closes #47471

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jan 16, 2022
@RyanCavanaugh
Copy link
Copy Markdown
Member

@sheetalkamat this seems worthy of signaling your attention for

@typescript-bot typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 20, 2022
@JoostK JoostK force-pushed the reuse-structure-dts-update branch from b78cd0a to a04fb9e Compare January 21, 2022 17:51
@andrewbranch
Copy link
Copy Markdown
Member

This seems fine to me but I'll wait a bit to see if Sheetal wants to take a quick look

@sheetalkamat
Copy link
Copy Markdown
Member

I can take a look next week and get back

Copy link
Copy Markdown
Member

@sheetalkamat sheetalkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks correct

@JoostK JoostK force-pushed the reuse-structure-dts-update branch from a04fb9e to 040fc26 Compare January 25, 2022 18:11
@JoostK
Copy link
Copy Markdown
Contributor Author

JoostK commented Jan 25, 2022

This is good to go from my side.

@andrewbranch andrewbranch merged commit ba402e6 into microsoft:main Jan 25, 2022
@JoostK
Copy link
Copy Markdown
Contributor Author

JoostK commented Jan 25, 2022

Can this also be cherry-picked into release-4.6 (i.e. the 4.6 beta), assuming that main is targeting 4.7 development?

@DanielRosenwasser
Copy link
Copy Markdown
Member

The main branch actually does still target 4.6 until we hit 4.6 RC, so this change should make its way into TS 4.6 (or nightly if you need it sooner 🙂).

@JoostK
Copy link
Copy Markdown
Contributor Author

JoostK commented Jan 25, 2022

Ah, excellent, that works for me :-) Thanks for the quick turnaround times on this PR, much appreciated!

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No structure reuse when a declaration file within a package is updated

6 participants